Skip to content

fix(patch.js): fix functional component scope attribute update #11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(patch.js): fix functional component scope attribute update #11247

wants to merge 1 commit into from

Conversation

mydaoyuan
Copy link

fix functional component update scope attribute when patch use same node

fix #11171

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

fix(patch.js): fix functional component scope attribute update
ef4ae7d 
fix functional component update scope attribute when patch use same node

fix vuejs#11171
@mydaoyuan
Copy link
Author

mydaoyuan commented Mar 27, 2020 •
edited
Loading 

Running:  select2
 ✖ Timed out while waiting for element <.select2> to be present for 1000 milliseconds.  - expected "visible" but got: "not found"
    at Object.select2 (/root/project/vue/test/e2e/specs/select2.js:6:8)
    at process._tickCallback (internal/process/next_tick.js:61:11)


FAILED:  1 assertions failed (2.329s)

i dont know how to fix this test error T T

@mydaoyuan mydaoyuan closed this Mar 27, 2020
@mydaoyuan mydaoyuan reopened this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swapping from functional to non-functional component using v-if does not change v-data-* attribute.
1 participant
@mydaoyuan